Skip to content

Conversation

@infiniteregrets
Copy link
Member

No description provided.

@infiniteregrets infiniteregrets force-pushed the fix/cross-container-image branch from 9e951c4 to cb8d9da Compare January 29, 2026 05:16
@greptile-apps
Copy link

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

Added Cross.toml configuration file to pin cross-rs container images to version 0.2.5 for musl targets, building on PR #112 which pinned the cross CLI itself to a known working commit.

  • Pins aarch64-unknown-linux-musl container to ghcr.io/cross-rs/aarch64-unknown-linux-musl:0.2.5
  • Pins x86_64-unknown-linux-musl container to ghcr.io/cross-rs/x86_64-unknown-linux-musl:0.2.5
  • Ensures reproducible builds by locking both the cross tool and its container images
  • Only affects musl targets used with use_cross: true in the release workflow

Confidence Score: 5/5

  • Safe to merge - straightforward configuration change that improves build reproducibility
  • Configuration correctly pins container images to match the previously pinned cross CLI version, follows cross-rs configuration format, and only affects CI/CD build reproducibility without changing runtime behavior
  • No files require special attention

Important Files Changed

Filename Overview
Cross.toml Added configuration to pin cross container images to version 0.2.5 for both aarch64 and x86_64 musl targets

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant Cross as Cross CLI
    participant Container as Container Registry
    participant Build as Build Process

    Dev->>GH: Push commit / Trigger release
    GH->>GH: Install cross from git rev 846d469b
    GH->>Cross: Read Cross.toml configuration
    Cross->>Container: Pull ghcr.io/cross-rs/aarch64-unknown-linux-musl:0.2.5
    Cross->>Container: Pull ghcr.io/cross-rs/x86_64-unknown-linux-musl:0.2.5
    Container-->>Cross: Return pinned container images
    Cross->>Build: Execute build in containerized environment
    Build-->>GH: Return compiled binaries
    GH->>GH: Package and upload artifacts
Loading

@infiniteregrets infiniteregrets merged commit d77f570 into main Jan 29, 2026
5 checks passed
@infiniteregrets infiniteregrets deleted the fix/cross-container-image branch January 29, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant